tomstepp commented on code in PR #33596:
URL: https://github.com/apache/beam/pull/33596#discussion_r1931315438
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -1066,26 +1082,21 @@ public Read<K, V>
withTopicPartitions(List<TopicPartition> topicPartitions) {
* Sets redistribute transform that hints to the runner to try to
redistribute the work evenly.
*/
public Read<K, V> withRedistribute() {
- if (getRedistributeNumKeys() == 0 && isRedistributed()) {
- LOG.warn("This will create a key per record, which is sub-optimal for
most use cases.");
- }
return toBuilder().setRedistributed(true).build();
}
public Read<K, V> withAllowDuplicates(Boolean allowDuplicates) {
- if (!isAllowDuplicates()) {
- LOG.warn("Setting this value without setting withRedistribute() will
have no effect.");
- }
return toBuilder().setAllowDuplicates(allowDuplicates).build();
}
public Read<K, V> withRedistributeNumKeys(int redistributeNumKeys) {
Review Comment:
TODO(tomstepp): Need to update testNumKeysIgnoredWithRedistributeNotEnabled
if removing check failure, or change warning in checkRedistributeConfiguration
to an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
