Abacn commented on code in PR #33803:
URL: https://github.com/apache/beam/pull/33803#discussion_r1935796794


##########
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java:
##########
@@ -1192,7 +1192,13 @@ private String quoteField(String field) {
     }
 
     private String quoteField(String field, String quotation) {

Review Comment:
   consider rename this private method (and its overload above) to sth like 
"quoteNonEmptyField" for clarity



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to