Abacn commented on code in PR #33574:
URL: https://github.com/apache/beam/pull/33574#discussion_r1943269752
##########
runners/google-cloud-dataflow-java/worker/build.gradle:
##########
@@ -250,6 +250,14 @@ project.task('validateShadedJarContainsSlf4jJdk14',
dependsOn: 'shadowJar') {
}
}
+project.tasks.withType(Test).configureEach {
Review Comment:
why are they needed? tests currently using Java11 should be fine as
https://openjdk.org/jeps/403 is enforced in Java16+ only.
Did you run tests on Java 17+ locally? If so did the test experience similar
issue on master branch?
##########
sdks/java/io/sparkreceiver/2/build.gradle:
##########
@@ -43,8 +43,8 @@ dependencies {
implementation library.java.commons_lang3
implementation library.java.joda_time
implementation library.java.slf4j_api
- implementation library.java.spark_streaming
- implementation library.java.spark_core
+ implementation library.java.spark3_streaming
Review Comment:
let's move sparkreceiver/2 to sparkreceiver/3 or simply sparkreceiver/. The
package name is unchanged so that release is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
