shunping commented on code in PR #33845: URL: https://github.com/apache/beam/pull/33845#discussion_r1943660539
########## sdks/python/apache_beam/ml/anomaly/base_test.py: ########## @@ -0,0 +1,210 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from __future__ import annotations + +import logging +import unittest + +from apache_beam.ml.anomaly.base import AggregationFn +from apache_beam.ml.anomaly.base import AnomalyDetector +from apache_beam.ml.anomaly.base import EnsembleAnomalyDetector +from apache_beam.ml.anomaly.base import ThresholdFn +from apache_beam.ml.anomaly.specifiable import Spec +from apache_beam.ml.anomaly.specifiable import Specifiable +from apache_beam.ml.anomaly.specifiable import specifiable + + +class TestAnomalyDetector(unittest.TestCase): + @specifiable(on_demand_init=False) + class DummyThreshold(ThresholdFn): + def __init__(self, my_threshold_arg=None): + ... + + def is_stateful(self): + return False + + def threshold(self): + ... + + def apply(self, x): + ... + + @specifiable(on_demand_init=False) + class Dummy(AnomalyDetector): + def __init__(self, my_arg=None, **kwargs): + self._my_arg = my_arg + super().__init__(**kwargs) + + def learn_one(self): + ... + + def score_one(self): + ... + + def __eq__(self, value) -> bool: + return isinstance(value, TestAnomalyDetector.Dummy) and \ + self._my_arg == value._my_arg + + def test_unknown_detector(self): + self.assertRaises(ValueError, Specifiable.from_spec, Spec(type="unknown")) Review Comment: Agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
