robertwb commented on code in PR #33482: URL: https://github.com/apache/beam/pull/33482#discussion_r1943730420
########## sdks/python/apache_beam/metrics/metric.py: ########## @@ -339,8 +339,8 @@ class Lineage: for lineage tracking.""" LINEAGE_NAMESPACE = "lineage" - SOURCE = "sources" - SINK = "sinks" + SOURCE = "sources_v2" Review Comment: The division between the namespace and non-namespace portion of a name are somewhat arbitrary... Keeping the namespace the same is nice because it allows one to query for all lineage counters (even as they evolve) but I don't feel too strongly about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
