shunping commented on code in PR #33845: URL: https://github.com/apache/beam/pull/33845#discussion_r1947181893
########## sdks/python/apache_beam/ml/anomaly/specifiable.py: ########## @@ -0,0 +1,223 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from __future__ import annotations + +import dataclasses +import inspect +import logging +from typing import Any +from typing import ClassVar +from typing import List +from typing import Protocol +from typing import Type +from typing import TypeVar +from typing import runtime_checkable + +from typing_extensions import Self + +ACCEPTED_SPECIFIABLE_SUBSPACES = [ Review Comment: (a) Yes, I think the subspace is transparent to users. Users don't need to specify subspace when they use the decorator to augment their class. (b) When there is a conflict, users can choose to specify a different `spec_type` when calling the decorator. I will make sure I have added that clearly in the docstring of the decorator. On a second thought, I think it may be helpful to turn KNOWN_SPECIFIABLE into a module private variable, so users will know they are not supposed to manage it directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
