ahmedabu98 commented on code in PR #33504:
URL: https://github.com/apache/beam/pull/33504#discussion_r1948358358
##########
sdks/java/io/iceberg/bqms/build.gradle:
##########
@@ -21,7 +21,9 @@ plugins {
applyJavaNature(
automaticModuleName: 'org.apache.beam.sdk.io.iceberg.bqms',
- shadowClosure: {},
+ shadowClosure: {
+ relocate "com.google.auth",
getJavaRelocatedPath("bqms.com.google.auth")
Review Comment:
I had introduced a dep that conflicted with this, but it's not needed
anymore. Will clean this up, thx
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/SnapshotRange.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.iceberg;
+
+import com.google.auto.value.AutoValue;
+import java.io.Serializable;
+import org.apache.beam.sdk.schemas.AutoValueSchema;
+import org.apache.beam.sdk.schemas.annotations.DefaultSchema;
+import org.apache.beam.sdk.schemas.annotations.SchemaIgnore;
+import org.apache.iceberg.catalog.TableIdentifier;
+import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
+@DefaultSchema(AutoValueSchema.class)
+@AutoValue
+abstract class SnapshotRange implements Serializable {
+ private transient @MonotonicNonNull TableIdentifier cachedTableIdentifier;
+
+ static Builder builder() {
+ return new AutoValue_SnapshotRange.Builder();
+ }
+
+ abstract String getTableIdentifierString();
+
+ abstract @Nullable Long getFromSnapshotExclusive();
Review Comment:
Correct. That's mentioned in the IcebergIO java doc, but sure I can include
it here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
