lostluck commented on PR #33881:
URL: https://github.com/apache/beam/pull/33881#issuecomment-2651933596

   Thanks for the review!
   
   At this stage the next best move is to separate the different stage types, 
now that there's clarity in how each needs to function. It's fine when there 
are two different kinds (stateful and not stateful), but aggregation adds 
sufficient complexity that this won't be as maintainable without much care and 
reading to know which cyclomatic clause you're dealing with.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to