kennknowles commented on code in PR #33989:
URL: https://github.com/apache/beam/pull/33989#discussion_r1955401054
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingSideInputFetcher.java:
##########
@@ -320,7 +320,10 @@ private <SideWindowT extends BoundedWindow>
Windmill.GlobalDataRequest buildGlob
.build())
.setExistenceWatermarkDeadline(
WindmillTimeUtils.harnessToWindmillTimestamp(
-
sideWindowStrategy.getTrigger().getWatermarkThatGuaranteesFiring(sideInputWindow)))
+ sideWindowStrategy
Review Comment:
I think that triggers cannot actually give a tight bound. You either have to
change _all_ of them to return `maxTimestamp + allowedLateness` or just take
the minimum here. I would suggest keeping it simple and doing the minimum here.
In fact, I would even support deleting the method from `Trigger` and doing all
of the logic here, since it is really just a one-off special case for
AfterWatermark / DefaultTrigger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
