TheNeuralBit commented on a change in pull request #12738:
URL: https://github.com/apache/beam/pull/12738#discussion_r482608677
##########
File path:
sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/BeamSqlLineIT.java
##########
@@ -198,12 +202,15 @@ private String taxiRideJSON(
return objectNode.toString();
}
+ /** Suppressing this due to
https://github.com/typetools/checker-framework/issues/979. */
+ @SuppressWarnings("return.type.incompatible")
private Future<List<List<String>>> runQueryInBackground(String[] args) {
return pool.submit(
(Callable)
() -> {
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
- BeamSqlLine.runSqlLine(args, null, outputStream, null);
+ InputStream inputStream = new ByteArrayInputStream(new byte[0]);
+ BeamSqlLine.runSqlLine(args, inputStream, outputStream, null);
Review comment:
Could we add an annotation to runSqlLine to suppress that warning? That
seems preferable to creating InputStream instances that aren't actually used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
