shunping commented on code in PR #33994: URL: https://github.com/apache/beam/pull/33994#discussion_r1960416493
########## sdks/python/apache_beam/ml/anomaly/univariate/quantile.py: ########## @@ -0,0 +1,171 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Trackers for calculating quantiles in windowed fashion. + +This module defines different types of quantile trackers that operate on +windows of data. It includes: + + * `SimpleSlidingQuantileTracker`: Calculates quantile using numpy in a sliding + window. + * `BufferedLandmarkQuantileTracker`: Sortedlist based quantile tracker in + landmark window mode. + * `BufferedSlidingQuantileTracker`: Sortedlist based quantile tracker in + sliding window mode. +""" + +import math +import typing +import warnings + +import numpy as np +from sortedcontainers import SortedList + +from apache_beam.ml.anomaly.univariate.base import WindowedTracker +from apache_beam.ml.anomaly.univariate.base import WindowMode + + +class QuantileTracker(WindowedTracker): + """Abstract base class for quantile trackers. + + Currently, it does not add any specific functionality but provides a type + hierarchy for quantile trackers. + """ + pass + + +class SimpleSlidingQuantileTracker(QuantileTracker): + """Sliding window quantile tracker using NumPy. + + This tracker uses NumPy's `nanquantile` function to calculate the specified + quantile of the values currently in the sliding window. It's a simple, + non-incremental approach. + + Args: + window_size: The size of the sliding window. + q: The quantile to calculate, a float between 0 and 1 (inclusive). + """ + def __init__(self, window_size, q): + super().__init__(window_mode=WindowMode.SLIDING, window_size=window_size) + assert 0 <= q <= 1, "quantile argument should be between 0 and 1" + self._q = q Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
