Abacn commented on code in PR #34019:
URL: https://github.com/apache/beam/pull/34019#discussion_r1962045140
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/datastore/RampupThrottlingFnTest.java:
##########
@@ -50,7 +49,7 @@ public class RampupThrottlingFnTest {
@Mock private Counter mockCounter;
private final Sleeper mockSleeper =
millis -> {
- verify(mockCounter).inc(millis);
Review Comment:
would you mind explain a little bit how this fixed the flaky test
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/datastore/RampupThrottlingFnTest.java:
##########
@@ -50,7 +49,7 @@ public class RampupThrottlingFnTest {
@Mock private Counter mockCounter;
private final Sleeper mockSleeper =
millis -> {
- verify(mockCounter).inc(millis);
Review Comment:
would you mind explaining a little bit how this fixed the flaky test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
