wollowizard commented on code in PR #34024:
URL: https://github.com/apache/beam/pull/34024#discussion_r1964194303
##########
buildSrc/build.gradle.kts:
##########
@@ -45,7 +45,7 @@ dependencies {
implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:5.0.14")
runtimeOnly("com.google.protobuf:protobuf-gradle-plugin:0.8.13")
// Enable proto code generation
- runtimeOnly("com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1")
// Enable Avro code generation
+ runtimeOnly("com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.1.0")
// Enable Avro code generation. Version 1.1.0 is
the last supporting avro 1.10.2
Review Comment:
restored 1.9.1. My thinking is that since the earliest tested avro version
is 1.10.2 (see `sdks/java/extensions/avro/build.gradle`) , it would be good to
use a version of the avro plugin that uses avro 1.10.2.
In any case, the whole plugin seems no longer maintained, so maybe it would
be a good idea to remove this altogether and just use the avro-tools jar, like
elsewhere. seems like this could be addressed in a separate task though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
