Naireen commented on code in PR #33503:
URL: https://github.com/apache/beam/pull/33503#discussion_r1964919555
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerImpl.java:
##########
@@ -293,6 +293,13 @@ public MetricUpdates getUpdates() {
.setLabel(MonitoringInfoConstants.Labels.NAME,
metricKey.metricName().getName())
.setLabel(MonitoringInfoConstants.Labels.PTRANSFORM,
metricKey.stepName());
}
+
+ // Based on namespace, add per worker metrics label to enable separate
runner based sink based
+ // processing.
+ if (metricName.getNamespace().equals("BigQuerySink")
Review Comment:
Done. Removed BQ sink support, that can be done later. I've added it to
MetricName
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
