Abacn commented on code in PR #33684: URL: https://github.com/apache/beam/pull/33684#discussion_r1966569823
########## runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java: ########## @@ -41,19 +41,18 @@ import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; import static org.junit.Assume.assumeFalse; -import static org.mockito.Matchers.any; -import static org.mockito.Matchers.anyListOf; -import static org.mockito.Matchers.eq; -import static org.mockito.Matchers.isA; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyList; +import static org.mockito.ArgumentMatchers.eq; +import static org.mockito.ArgumentMatchers.isA; +import static org.mockito.Mockito.CALLS_REAL_METHODS; Review Comment: Thanks for this change. It is also helpful to enable running DataflowRunner tests internally (powermockito not available in internal code base). However Mockito.mockStstic still not available internally (tracker: 233118689). Proposed to split tests involving mockStstic outside of DataflowRunnerTest in #34054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
