clairemcginty commented on code in PR #34059:
URL: https://github.com/apache/beam/pull/34059#discussion_r1968504722
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProtoTest.java:
##########
@@ -456,8 +464,8 @@ enum TestEnum {
.put("numericvalue", numericBytes)
.put("bignumericvalue", bigNumericBytes)
.put("datevalue", 42)
- .put("timemicrosvalue", 42_000_000L)
- .put("timemillisvalue", 42_000_000L)
+ .put("timemicrosvalue",
CivilTimeEncoder.encodePacked64TimeMicros(localTime))
Review Comment:
I was curious so I checked the difference here. CivilTimeEncoder translates
this value to `44,040,192` compared to the original `42,000,000`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
