m-trieu commented on code in PR #34061:
URL: https://github.com/apache/beam/pull/34061#discussion_r1970314458
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/WindmillChannelFactory.java:
##########
@@ -126,7 +132,7 @@ private WindmillChannelCreationException(HostAndPort
endpoint, SSLException sour
super(
String.format(
"Exception thrown when trying to create channel to
endpoint={host:%s; port:%d}",
- endpoint.getHost(), endpoint.getPort()),
+ endpoint.getHost(), endpoint.hasPort() ? endpoint.getPort() :
-1),
Review Comment:
its a vendored dep in the guava library so i will make a wrapper class and
enforce that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
