damccorm commented on PR #33192:
URL: https://github.com/apache/beam/pull/33192#issuecomment-2682970239

   > hi! I was wondering if there were plans to bump the [GrpcVendoring 
protobuf 
version](https://github.com/apache/beam/blob/v2.63.0/buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_69_0.groovy#L40)
 to 4.x as well? I also noticed when updating 
`beam-sdks-java-extensions-protobuf` to 2.63, it's transitively pulling 
`protobuf-java` 4.29 but `protobuf-java-util` 3.25:
   > 
   > ```shell
   > % cs resolve org.apache.beam:beam-sdks-java-extensions-protobuf:2.63.0
   > args4j:args4j:2.33:default
   > com.charleskorn.kaml:kaml:0.20.0:default
   > com.fasterxml.jackson.core:jackson-annotations:2.15.4:default
   > com.fasterxml.jackson.core:jackson-core:2.16.1:default
   > com.fasterxml.jackson.core:jackson-databind:2.15.4:default
   > ...
   > com.google.protobuf:protobuf-java:4.29.0:default
   > com.google.protobuf:protobuf-java-util:3.25.2:default
   > ```
   > 
   > and `beam-sdks-java-extensions-google-cloud-platform-core` only pulls in 
3.25:
   > 
   > ```shell
   > % cs resolve 
org.apache.beam:beam-sdks-java-extensions-google-cloud-platform-core:2.63.0
   > args4j:args4j:2.33:default
   > com.fasterxml.jackson.core:jackson-annotations:2.15.4:default
   > com.fasterxml.jackson.core:jackson-core:2.18.0:default
   > com.fasterxml.jackson.core:jackson-databind:2.15.4:default
   > ...
   > com.google.protobuf:protobuf-java:3.25.5:default
   > com.google.protobuf:protobuf-java-util:3.25.5:default
   > ```
   
   That dependency comes from 
https://github.com/grpc/grpc-java/blob/34a7cffcf3dca012cd3e48da14d127c3afd924bf/gradle/libs.versions.toml#L9
 so we would either need to wait for a new grpc release or we'd need to 
override this version (which may have unknown consequences). Because of this 
setup and the requirements of the Google BOM, historically, we have not kept 
these versions in sync.
   
   3.25.x is theoretically supposed to have some compatibility guarantees with 
4.x so that they can work together, is that specifically giving you problems?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to