Re: [PR] Fix race condition [beam]

Fri, 28 Feb 2025 09:57:08 -0800 


damccorm commented on PR #34058:
URL: https://github.com/apache/beam/pull/34058#issuecomment-2691193885

   Yeah, seems like little to no perf impact.
   
   My [run with this 
change](https://github.com/apache/beam/actions/runs/13592236722/job/38000902912):
   
   
![image](https://github.com/user-attachments/assets/1ebb6ce7-b1c9-4f3b-9039-f1e06e4b8dc6)
   
   Previous 5 runs:
   
   [run 1](https://github.com/apache/beam/actions/runs/13586064344):
   
   
![image](https://github.com/user-attachments/assets/71f80341-44ed-4155-8bcb-6e4f1898d6e1)
   
   [run 2](https://github.com/apache/beam/actions/runs/13576963293):
   
   
![image](https://github.com/user-attachments/assets/28900a3b-7a9a-475d-930b-9211fd208df2)
   
   [run 3](https://github.com/apache/beam/actions/runs/13564068853):
   
   
![image](https://github.com/user-attachments/assets/1d0d3967-7bb9-4ffd-b976-67bf32cdeb57)
   
   [run 4](https://github.com/apache/beam/actions/runs/13554463358):
   
   
![image](https://github.com/user-attachments/assets/70be668d-9fb3-4421-8973-f2bd648c1806)
   
   [run 5](https://github.com/apache/beam/actions/runs/13541591273):
   
   
![image](https://github.com/user-attachments/assets/ab8bcfbc-879b-4b8c-a57f-21ad4be87c83)
   
   My updated version actually did the best here on both metrics, so it seems 
like it should be pretty safe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to