derrickaw commented on code in PR #34127:
URL: https://github.com/apache/beam/pull/34127#discussion_r1976496045


##########
sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java:
##########
@@ -536,7 +545,7 @@ public List<BoundedSource<Document>> split(
             LOG.debug("using filters: " + allFilters.toJson());
             sources.add(new 
BoundedMongoDbSource(spec.withQueryFn(queryWithFilter)));
           }
-        } else {
+        } else if (spec.queryFn().getClass() == 
AutoValue_AggregationQuery.class) {

Review Comment:
   done, thanks



##########
sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java:
##########
@@ -312,7 +318,10 @@ public Read withBucketAuto(boolean bucketAuto) {
       return builder().setBucketAuto(bucketAuto).build();
     }
 
-    /** Sets a queryFn. */
+    /**
+     * Sets a queryFn. The provided queryFn must be one of the predefined 
classes in the MongoDbIO
+     * package such as FindQuery or AggregationQuery.

Review Comment:
   done, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to