Abacn commented on code in PR #34161:
URL: https://github.com/apache/beam/pull/34161#discussion_r1981771285
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
@@ -177,7 +177,14 @@ static SpannerOptions buildSpannerOptions(SpannerConfig
spannerConfig) {
.setInitialRpcTimeout(org.threeten.bp.Duration.ofMinutes(120))
.setMaxRpcTimeout(org.threeten.bp.Duration.ofMinutes(120))
.setTotalTimeout(org.threeten.bp.Duration.ofMinutes(120))
+ .setRpcTimeoutMultiplier(1.0)
+ .setInitialRetryDelay(org.threeten.bp.Duration.ofSeconds(2))
Review Comment:
setInitialRetryDelay, setMaxRetryDelay are marked as ObsoleteApi by Spanner
client. Consider move to use setInitialRetryDelayDuration with
java.time.Duration parameters. Could take the chance to also fix the parameters
around (setInitialRpcTimeout, setMaxRpcTimeout, setTotalTimeout)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
