Naireen commented on code in PR #33503:
URL: https://github.com/apache/beam/pull/33503#discussion_r1986936298
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingStepMetricsContainer.java:
##########
@@ -388,7 +372,8 @@ private void deleteStaleCounters(
@VisibleForTesting
Iterable<PerStepNamespaceMetrics> extractPerWorkerMetricUpdates() {
ConcurrentHashMap<MetricName, Long> counters = new
ConcurrentHashMap<MetricName, Long>();
- ConcurrentHashMap<MetricName, Long> gauges = new
ConcurrentHashMap<MetricName, Long>();
+ ConcurrentHashMap<MetricName, Long> per_worker_gauges =
Review Comment:
I agree, that should be done for all of them, will do that in the followup
clean up CL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
