Suvrat1629 commented on PR #34194: URL: https://github.com/apache/beam/pull/34194#issuecomment-2715058947
@Abacn I have tried my best to add tests please take a look. To make the test `testProtoCoderWithRawMessageInterfaceThrowsException` fail, revert the changes in `ProtoCoder.getParser()` by removing the early check if `(Message.class.equals(protoMessageClass))` that throws the "ProtoCoder does not support the raw Message interface..." exception. This will cause `getParser()` to attempt `getDefaultInstance()` on Message.class, triggering a `NoSuchMethodException` wrapped in an `IllegalArgumentException`, and the test will fail due to the message mismatch. To make the test pass again, restore the original change with the if `(Message.class.equals(protoMessageClass))` check, which throws the expected `IllegalArgumentException` with the correct message, aligning with the test’s expectation. See if this fits fine. Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
