damccorm commented on code in PR #34232: URL: https://github.com/apache/beam/pull/34232#discussion_r1987879689
########## sdks/python/apache_beam/ml/anomaly/detectors/iqr_test.py: ########## @@ -0,0 +1,52 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +import logging +import math +import unittest + +import apache_beam as beam +from apache_beam.ml.anomaly.detectors.iqr import IQR + + +class IQRTest(unittest.TestCase): + input = [ + beam.Row(x=1), + beam.Row(x=1), + beam.Row(x=5), + beam.Row(x=9), + beam.Row(x=20), + beam.Row(x=10), + beam.Row(x=1) + ] + + def test_with_default_trackers(self): + iqr = IQR() + + scores = [] + for row in IQRTest.input: + scores.append(iqr.score_one(row)) + iqr.learn_one(row) + + self.assertTrue(math.isnan(scores[0])) + self.assertEqual( + scores[1:], [0.0, 0.0, 3.0, 2.8, 0.125, 0.12903225806451613]) Review Comment: It might be a bit more friendly, though I'm not sure how big of a difference it will make. I think it will be rare for users to compare values like we do here, more likely they'd be doing comparisons like `math.isnan(x)` and `x is None`. But it might make testing a little more annoying. I'd say lets scope it out of this PR, but if you want to flip the meaning back I am fine with that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
