damccorm commented on code in PR #34217:
URL: https://github.com/apache/beam/pull/34217#discussion_r1987362872
##########
release/src/main/scripts/build_release_candidate.sh:
##########
@@ -372,6 +372,7 @@ if [[ $confirmation = "y" ]]; then
cd ${BEAM_ROOT_DIR}
./gradlew :sdks:python:generateYamlDocs -PisRelease
GENERATE_YAMLDOC=~/${LOCAL_WEBSITE_UPDATE_DIR}/${LOCAL_YAML_DOC}/${BEAM_ROOT_DIR}/sdks/python/build/yaml-ref.html
+
GENERATE_YAMLDOC_EXAMPLES=~/${LOCAL_WEBSITE_UPDATE_DIR}/${LOCAL_YAML_DOC}/${BEAM_ROOT_DIR}/sdks/python/build/yaml-examples.html
Review Comment:
Its fine to leave this, but I think we can actually just get rid of this
script.
##########
.github/workflows/build_release_candidate.yml:
##########
@@ -391,6 +391,7 @@ jobs:
echo "............Copying generated yamldoc into
beam-site.........."
mkdir -p yamldoc/${{ github.event.inputs.RELEASE }}
cp -r ${BEAM_ROOT_DIR}/sdks/python/build/yaml-ref.html yamldoc/${{
github.event.inputs.RELEASE }}/index.html
+ cp -r ${BEAM_ROOT_DIR}/sdks/python/build/yaml-eamples.html
yamldoc/${{ github.event.inputs.RELEASE }}/examples.html
Review Comment:
```suggestion
cp -r ${BEAM_ROOT_DIR}/sdks/python/build/yaml-examples.html
yamldoc/${{ github.event.inputs.RELEASE }}/examples.html
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
