mataralhawiti opened a new issue, #34224:
URL: https://github.com/apache/beam/issues/34224

   ### What happened?
   
   I was reading through the Triggers examples, and I feel there's a typo in 
https://beam.apache.org/documentation/programming-guide/#composite-afterwatermark
   
   
   Here's the example description from docs:
   > You can express this pattern using AfterWatermark. For example, the 
following example trigger code fires on the following conditions:
   > 
   > On Beam’s estimate that all the data has arrived (the watermark passes the 
end of the window)
   > 
   > Any time late data arrives, after a ten-minute delay
   > 
   > After two days, we assume no more data of interest will arrive, and the 
trigger stops executing
   <br>
   
   
   ```
   pcollection | WindowInto(
       FixedWindows(1 * 60),
       trigger=AfterWatermark(late=AfterProcessingTime(10 * 60)),
   
       
       allowed_lateness=10, ###--> I think it should be allowed_lateness=2
       accumulation_mode=AccumulationMode.DISCARDING)
   ```
   
   
   
   ### Issue Priority
   
   Priority: 3 (minor)
   
   ### Issue Components
   
   - [x] Component: Python SDK
   - [ ] Component: Java SDK
   - [ ] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [ ] Component: IO connector
   - [ ] Component: Beam YAML
   - [x] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [ ] Component: Website
   - [ ] Component: Infrastructure
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to