kennknowles commented on code in PR #33037:
URL: https://github.com/apache/beam/pull/33037#discussion_r1987545549
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SimpleParDoFn.java:
##########
@@ -516,10 +520,14 @@ private <W extends BoundedWindow> void
registerStateCleanup(
private Instant earliestAllowableCleanupTime(
BoundedWindow window, WindowingStrategy windowingStrategy) {
- return window
- .maxTimestamp()
- .plus(windowingStrategy.getAllowedLateness())
- .plus(Duration.millis(1L));
+ Instant cleanupTime =
+ window
+ .maxTimestamp()
+ .plus(windowingStrategy.getAllowedLateness())
+ .plus(Duration.millis(1L));
+ return cleanupTime.isAfter(BoundedWindow.TIMESTAMP_MAX_VALUE)
Review Comment:
I think this can be capped to `GlobalWindow.INSTANCE.maxTimestamp()`. Is
that not so?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
