Abacn commented on code in PR #34253:
URL: https://github.com/apache/beam/pull/34253#discussion_r1991697412


##########
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkStreamingPortablePipelineTranslator.java:
##########
@@ -322,13 +342,21 @@ private static <T> void translateFlatten(
           dStreams.add(unboundedDataset.getDStream());
         } else {
           // create a single RDD stream.
-          final SingleEmitInputDStream<WindowedValue<T>> 
singleEmitInputDStream =
-              new SingleEmitInputDStream<WindowedValue<T>>(
-                  context.getStreamingContext().ssc(), ((BoundedDataset) 
dataset).getRDD().rdd());
-          final JavaDStream<WindowedValue<T>> dStream =
-              JavaDStream.fromDStream(
-                  singleEmitInputDStream, 
JavaSparkContext$.MODULE$.fakeClassTag());
-
+          JavaDStream<WindowedValue<T>> dStream;
+          if (context.getSparkContext().version().startsWith("3")) {
+            Queue<JavaRDD<WindowedValue<T>>> q = new LinkedBlockingQueue<>();
+            q.offer(((BoundedDataset) dataset).getRDD());
+            // TODO (https://github.com/apache/beam/issues/20426): this is not 
recoverable from

Review Comment:
   This adds back a previously closed issue #20426 that  #34080 intended to 
solve. To what extent #34080 still functioning, or shall we revert it as a 
whole?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to