scwhittle commented on code in PR #34292:
URL: https://github.com/apache/beam/pull/34292#discussion_r1995300389
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java:
##########
@@ -64,10 +65,8 @@ class WindmillTimerInternals implements TimerInternals {
// though technically in Windmill this is only enforced per ID and namespace
// and TimeDomain. This TimerInternals is scoped to a step and key, shared
// across namespaces.
- private final Table<String, StateNamespace, TimerData> timers =
HashBasedTable.create();
-
- // Map from timer id to whether it is to be deleted or set
- private final Table<String, StateNamespace, Boolean> timerStillPresent =
HashBasedTable.create();
+ private final Map<Entry<String /*ID*/, StateNamespace>, Entry<TimerData,
Boolean>> timerMap =
Review Comment:
Alternatively maybe we could use a TreeMap with a custom comparator?
Then we could avoid some of the wrapper allocations
If not is there a reason to use LinkedHashMap instead of just HashMap? Do we
need the stable iteration for any reason?
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java:
##########
@@ -64,10 +65,8 @@ class WindmillTimerInternals implements TimerInternals {
// though technically in Windmill this is only enforced per ID and namespace
// and TimeDomain. This TimerInternals is scoped to a step and key, shared
// across namespaces.
- private final Table<String, StateNamespace, TimerData> timers =
HashBasedTable.create();
-
- // Map from timer id to whether it is to be deleted or set
- private final Table<String, StateNamespace, Boolean> timerStillPresent =
HashBasedTable.create();
+ private final Map<Entry<String /*ID*/, StateNamespace>, Entry<TimerData,
Boolean>> timerMap =
Review Comment:
comment on what boolean is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
