monicadsong commented on a change in pull request #12756:
URL: https://github.com/apache/beam/pull/12756#discussion_r483215632
##########
File path: sdks/python/apache_beam/transforms/stats.py
##########
@@ -192,7 +193,7 @@ def get_estimate(self):
if len(self._sample_heap) < self._sample_size:
return len(self._sample_heap)
else:
- sample_space_size = sys.maxsize - 1.0 * self._min_hash
+ sample_space_size = self._HASH_SPACE_SIZE - 1.0 * self._min_hash
Review comment:
Modified it to 2^63 - 1 (which is also equivalent to sys.maxsize...
which is why my tests were passing.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
