damccorm commented on code in PR #34323:
URL: https://github.com/apache/beam/pull/34323#discussion_r1999572630
##########
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisTransformRegistrar.java:
##########
@@ -64,6 +64,7 @@ private abstract static class CrossLanguageConfiguration {
String region;
@Nullable String serviceEndpoint;
boolean verifyCertificate;
+ boolean aggregationEnabled;
Review Comment:
This seems helpful - if we're going to do this, could we also expose the
properties here?
https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.RecordAggregation.Builder.html
e.g.
```
maxAggregationBufferedTime
maxAggregationBytes
aggregationShardRefreshInterval
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
