Abacn commented on code in PR #34057:
URL: https://github.com/apache/beam/pull/34057#discussion_r2001339825
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/UnboundedReadFromBoundedSourceTest.java:
##########
@@ -262,7 +261,7 @@ public void testInvokesSplitWithDefaultNumSplitsTooLarge()
throws Exception {
PipelineOptions options = PipelineOptionsFactory.create();
List<?> splits = unboundedCountingSource.split(100, options);
assertEquals(1, splits.size());
- assertNotEquals(splits.get(0), unboundedCountingSource);
+ assertEquals(splits.get(0), unboundedCountingSource);
Review Comment:
Interesting, this means "assertNotEquals" didn't actually check that split
has been invoked always
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/UnboundedReadFromBoundedSourceTest.java:
##########
@@ -262,7 +261,7 @@ public void testInvokesSplitWithDefaultNumSplitsTooLarge()
throws Exception {
PipelineOptions options = PipelineOptionsFactory.create();
List<?> splits = unboundedCountingSource.split(100, options);
assertEquals(1, splits.size());
- assertNotEquals(splits.get(0), unboundedCountingSource);
+ assertEquals(splits.get(0), unboundedCountingSource);
Review Comment:
Interesting, this means "assertNotEquals" didn't actually check that split
has been invoked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
