m-trieu commented on code in PR #34283:
URL: https://github.com/apache/beam/pull/34283#discussion_r2001984904
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/AbstractWindmillStream.java:
##########
@@ -236,14 +236,20 @@ protected final void executeSafely(Runnable runnable) {
}
}
- public final synchronized void maybeSendHealthCheck(Instant
lastSendThreshold) {
- if (!clientClosed && debugMetrics.getLastSendTimeMs() <
lastSendThreshold.getMillis()) {
- try {
- sendHealthCheck();
- } catch (Exception e) {
- logger.debug("Received exception sending health check.", e);
- }
- }
+ public final void maybeSendHealthCheck(Instant lastSendThreshold) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
