prodriguezdefino commented on PR #34327: URL: https://github.com/apache/beam/pull/34327#issuecomment-2734760682
> Thanks. Could you add some unit tests to cover `SqsReadSchemaTransformProvider` ? > > You can use [this](https://github.com/apache/beam/blob/master/sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/IcebergReadSchemaTransformProviderTest.java) as a template for unit tests. > > LGTM other than that. Thanks so much for the template pointer @chamikaramj! added few tests to check the right configuration and that the expected behavior for the externalized transform is the expected one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
