tamannakakkar93 commented on code in PR #34249:
URL: https://github.com/apache/beam/pull/34249#discussion_r1989597066


##########
sdks/python/apache_beam/io/gcp/bigquery_tools.py:
##########
@@ -787,7 +787,7 @@ def get_table(self, project_id, dataset_id, table_id):
       HttpError: if lookup failed.
     """
     request = bigquery.BigqueryTablesGetRequest(
-        projectId=project_id, datasetId=dataset_id, tableId=table_id)
+        projectId=project_id, datasetId=dataset_id, tableId=table_id, 
table_view='BASIC')

Review Comment:
   done
   
https://github.com/apache/beam/pull/34249/commits/294f23e99c910e2cf704a26f52df69d5c52aabc0



##########
sdks/python/apache_beam/io/gcp/bigquery_tools.py:
##########
@@ -772,7 +772,7 @@ def _insert_all_rows(
   @retry.with_exponential_backoff(
       num_retries=MAX_RETRIES,
       retry_filter=retry.retry_on_server_errors_timeout_or_quota_issues_filter)
-  def get_table(self, project_id, dataset_id, table_id):
+  def get_table(self, project_id, dataset_id, table_id, table_view='BASIC'):
     """Lookup a table's metadata object.

Review Comment:
   done
   



##########
sdks/python/apache_beam/io/gcp/bigquery_tools.py:
##########
@@ -787,7 +787,7 @@ def get_table(self, project_id, dataset_id, table_id):
       HttpError: if lookup failed.
     """
     request = bigquery.BigqueryTablesGetRequest(
-        projectId=project_id, datasetId=dataset_id, tableId=table_id)
+        projectId=project_id, datasetId=dataset_id, tableId=table_id, 
table_view=table_view)

Review Comment:
   @liferoad should it be TableMetadataView instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to