[GitHub] [beam] chamikaramj commented on a change in pull request #12713: Overriding BigQuerySource to ReadFromBigQuery starting with Beam 2.25.0

[GitBox]

chamikaramj commented on a change in pull request #12713:
URL: https://github.com/apache/beam/pull/12713#discussion_r483282665



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -118,13 +118,15 @@ class DataflowRunner(PipelineRunner):
   from apache_beam.runners.dataflow.ptransform_overrides import 
CreatePTransformOverride
   from apache_beam.runners.dataflow.ptransform_overrides import 
JrhReadPTransformOverride
   from apache_beam.runners.dataflow.ptransform_overrides import 
ReadPTransformOverride
+  from apache_beam.runners.dataflow.ptransform_overrides import 
ReadBigQuerySourcePTransformOverride
   from apache_beam.runners.dataflow.ptransform_overrides import 
NativeReadPTransformOverride
 
   # These overrides should be applied before the proto representation of the
   # graph is created.
   _PTRANSFORM_OVERRIDES = [
       CombineValuesPTransformOverride(),
       NativeReadPTransformOverride(),
+      ReadBigQuerySourcePTransformOverride(),

Review comment:
       Seems like we are creating the proto pipeline after applying the 
overrides: 
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py#L482
   
   So overrides will be reflected in the proto ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org