ihji commented on a change in pull request #12754:
URL: https://github.com/apache/beam/pull/12754#discussion_r483288994
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1198,8 +1209,34 @@ def process(self, element, *schema_side_inputs):
return self._flush_all_batches()
def finish_bundle(self):
+ current_millis = int(time.time() * 1000)
Review comment:
The three calls have their own role. One for remembering request time.
One for measuring response time so that we can subtract the start time from the
end time. And the last one is for checking log reporting interval.
We might slightly reduce the overhead by moving the last `time.time()` call
inside the synchronized block. In that case, the thread that skips the
synchronized section won't execute `time.time()` (probably the saving is small
though)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
