scwhittle commented on PR #34355: URL: https://github.com/apache/beam/pull/34355#issuecomment-2739812719
Beyond profile difference, did you see cpu usage drop with the PR? kind of hard to tell from profiles other than that it moved locations. Some benefits does seem like it would reduce memory since we don't have serialized commit in addition to grpc message frames which might get sent. Downside is that we are now serializing beneath the synchronized block for the stream which seems like it could cause some more contention if there are multiple commit threads since they just pull randomly from commit stream pool and may overlap. If this also helps cpu maybe that is moot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
