claudevdm commented on PR #34393: URL: https://github.com/apache/beam/pull/34393#issuecomment-2746637872
> @claudevdm -- it seems necessary as the end goal of this, as described in #34349 is to expose this to Beam YAML, which uses the ReadRows Transform when reading from JDBC. This PR seems like adds a new ReadRowsWithPartitions, which achieves the same as ReadWithPartitions.withRowOutput(). Can you help me understand why are we adding a new ReadRowsWithPartitions with almost the exact same code as ReadWithPartitions? ReadWithPartitions.withRowOutput() can be used from https://github.com/apache/beam/blob/3595a3303df6d2e4c8e77482ca8120994d0d5881/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcReadSchemaTransformProvider.java#L49 can it not? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
