damccorm commented on code in PR #34404:
URL: https://github.com/apache/beam/pull/34404#discussion_r2010875137
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -661,16 +661,20 @@ def create_transform(self, type, args,
yaml_create_transform):
return self._transform_factories[type](yaml_create_transform, **args)
+def get_default_sql_provider():
Review Comment:
Could we add a follow on PR adding a comment mentioning that this function
is special? Otherwise I worry that folks will accidentally overwrite it without
understanding the implications.
@robertwb in general it would probably be better if we could resolve
conversations before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
