sjvanrossum commented on code in PR #34420:
URL: https://github.com/apache/beam/pull/34420#discussion_r2012570921
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java:
##########
@@ -891,7 +899,7 @@ private Object createCacheKey(
// For caching reader, we don't care about the watermark.
return restrictionCoder.structuralValue(
UnboundedSourceRestriction.create(
- source, checkpoint, BoundedWindow.TIMESTAMP_MIN_VALUE));
+ source, checkpoint, BoundedWindow.TIMESTAMP_MIN_VALUE, null));
}
Review Comment:
Depending on whether source splits are kept locally or repeatedly sent over
the data API you might want to use the split id instead of the instance as a
key to avoid issues with source implementations that don't override
`#equals(Object)` and `#hashCode()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
