svetakvsundhar commented on PR #34426: URL: https://github.com/apache/beam/pull/34426#issuecomment-2752383523
Hi @ahmedabu98 , I think this PR is in a good place for some initial feedback. There are a couple of things/open notes I had: (1) Need to still implement this with the `PROTO` and `JSON` format (right now it's only supported with `RAW`. (2) It seems like the `ReadSchemaTransformProvider` doesn't have it's own file for integration tests. What are your thoughts on me creating a new file for integration tests, to test this change? Any other comments on the general design/flow would be good as well! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
