m-trieu commented on code in PR #34222:
URL: https://github.com/apache/beam/pull/34222#discussion_r2014556510
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java:
##########
@@ -962,13 +962,17 @@ static class InsertBatchofRowsCallable implements
Callable<List<InsertErrors>> {
private final TableReference ref;
private final Boolean skipInvalidRows;
- private final Boolean ignoreUnkownValues;
+ private final Boolean ignoreUnknownValues;
private final Bigquery client;
private final FluentBackoff rateLimitBackoffFactory;
private final List<TableDataInsertAllRequest.Rows> rows;
private final AtomicLong maxThrottlingMsec;
private final Sleeper sleeper;
private final StreamingInsertsMetrics result;
+ private final @Nullable InsertRetryPolicy retryPolicy;
+ private final @Nullable List<FailsafeValueInSingleWindow<TableRow,
TableRow>> originalRows;
Review Comment:
Can these 2 collections be represented as an empty list instead of null?
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java:
##########
@@ -962,13 +962,17 @@ static class InsertBatchofRowsCallable implements
Callable<List<InsertErrors>> {
private final TableReference ref;
private final Boolean skipInvalidRows;
- private final Boolean ignoreUnkownValues;
+ private final Boolean ignoreUnknownValues;
Review Comment:
Can this be the primitive Boolean type?
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java:
##########
@@ -980,67 +984,123 @@ static class InsertBatchofRowsCallable implements
Callable<List<InsertErrors>> {
AtomicLong maxThrottlingMsec,
Sleeper sleeper,
StreamingInsertsMetrics result) {
+ this(
+ ref,
+ skipInvalidRows,
+ ignoreUnknownValues,
+ client,
+ rateLimitBackoffFactory,
+ rows,
+ maxThrottlingMsec,
+ sleeper,
+ result,
+ null,
+ null,
+ null,
+ null);
+ }
+
+ InsertBatchofRowsCallable(
+ TableReference ref,
+ Boolean skipInvalidRows,
+ Boolean ignoreUnknownValues,
+ Bigquery client,
+ FluentBackoff rateLimitBackoffFactory,
+ List<TableDataInsertAllRequest.Rows> rows,
+ AtomicLong maxThrottlingMsec,
+ Sleeper sleeper,
+ StreamingInsertsMetrics result,
+ @Nullable InsertRetryPolicy retryPolicy,
+ @Nullable List<FailsafeValueInSingleWindow<TableRow, TableRow>>
originalRows,
Review Comment:
Can these 2 collections be represented as an empty list instead of null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
