damccorm commented on code in PR #34371:
URL: https://github.com/apache/beam/pull/34371#discussion_r2007569008
##########
release/src/main/scripts/set_version.sh:
##########
@@ -69,8 +69,8 @@ if [[ -z $TARGET_VERSION ]] ; then
exit 1
fi
-if ! [[ ${RELEASE} =~ ([0-9]+\.[0-9]+\.[0-9]+) ]];
- then echo "The input for RELEASE does not match a valid format
[0-9]+\.[0-9]+\.[0-9]+"
+if ! [[ ${RELEASE} =~ ([0-9]+\.[0-9]+) ]];
Review Comment:
Actually, I approved and merged, but I don't think this is the right fix.
RELEASE is totally unset, this is just the wrong variable name. I'll put up a PR
##########
release/src/main/scripts/set_version.sh:
##########
@@ -69,8 +69,8 @@ if [[ -z $TARGET_VERSION ]] ; then
exit 1
fi
-if ! [[ ${RELEASE} =~ ([0-9]+\.[0-9]+\.[0-9]+) ]];
- then echo "The input for RELEASE does not match a valid format
[0-9]+\.[0-9]+\.[0-9]+"
+if ! [[ ${RELEASE} =~ ([0-9]+\.[0-9]+) ]];
Review Comment:
https://github.com/apache/beam/pull/34378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
