m-trieu commented on code in PR #34053:
URL: https://github.com/apache/beam/pull/34053#discussion_r2023606989
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/BackendWorkerMetadataVendor.java:
##########
@@ -75,69 +81,77 @@ static BackendWorkerMetadataVendor create(
* Returns a {@link CompletableFuture} that can be used to block until the
initial {@link
* GetWorkerMetadataStream} has been started.
*/
- CompletableFuture<Void> start(Consumer<WindmillEndpoints> endpointsConsumer)
{
- if (isRunning.compareAndSet(false, true)) {
- LOG.debug("Starting WorkerMetadataVendor...");
-
- CountDownLatch initialStreamStarted = new CountDownLatch(1);
-
- workerMetadataFetcher.execute(
- () -> {
- boolean isInitialWorkerMetadata = true;
- WorkerMetadataResponse initialWorkerMetadata = NO_WORKER_METADATA;
-
- while (isRunning.get()) {
- GetWorkerMetadataStream getWorkerMetadataStream =
- getWorkerMetadataStreamFactory.create(initialWorkerMetadata,
endpointsConsumer);
- LOG.debug(
- "Starting GetWorkerMetadataStream w/ metadata version {}.",
- initialWorkerMetadata.getMetadataVersion());
- getWorkerMetadataStream.start();
-
- if (isInitialWorkerMetadata) {
- isInitialWorkerMetadata = false;
- initialStreamStarted.countDown();
+ synchronized void start(Consumer<WindmillEndpoints> endpointsConsumer) {
+ checkState(!isStarted, "Multiple calls to
BackendWorkerMetadataVendor.start() is not allowed.");
+ checkState(!isShutdown, "BackendWorkerMetadataVendor has previously been
shutdown.");
+ LOG.debug("Starting WorkerMetadataVendor...");
+
+ fetchBackendWorkerMetadataExecutor.execute(
+ () -> {
+ WorkerMetadataResponse initialWorkerMetadata = NO_WORKER_METADATA;
+
+ while (isStarted && !isShutdown) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
