piotr-szuberski commented on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-686969979
> Please keep this in apache_beam.io instead of apache_beam.io.external. There's not much value in differentiating cross-language IO connectors from other connectors. If you worry about backwards compatibility you can add a stub similar to https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/external/kafka.py I added a stub like in kafka.py. > > (also please make sure to add backwards compatibility warnings to all new transforms) I'm not sure about this part. Is the warning in the stub file sufficient or should I add some warning with WriteToSnowflake also? I think that only ReadFromSnowflake requires that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
