liferoad commented on code in PR #34379:
URL: https://github.com/apache/beam/pull/34379#discussion_r2027201422
##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -339,6 +346,139 @@ def should_garbage_collect_on_timeout(self) -> bool:
return self.share_model_across_processes()
+class RemoteModelHandler(ABC, ModelHandler[ExampleT, PredictionT, ModelT]):
+ """Has the ability to call a model at a remote endpoint."""
+ def __init__(
Review Comment:
I do not think it blocks your work. I just want to call out whether we want
to do more like
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/ml/anomaly/transforms.py#L61.
If the arguments keep growing, a config class might be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
