DKER2 commented on issue #34438: URL: https://github.com/apache/beam/issues/34438#issuecomment-2778067548
Hi @Abacn, actually this behavior is written in our test case [here](https://github.com/apache/beam/blob/aae44884faab9c81eaadb6587412f5c0eabfff9f/sdks/python/apache_beam/io/avroio_test.py#L198-L206). I think this behavior is a way for us to walk around because of value -1 will cause this [function](https://github.com/apache/beam/blob/aae44884faab9c81eaadb6587412f5c0eabfff9f/sdks/python/apache_beam/io/avroio_test.py#L198-L206)to fail. This function is called when we excecute SELECT SQL. I wonder why at first -1 caused the [function ](https://github.com/apache/beam/blob/aae44884faab9c81eaadb6587412f5c0eabfff9f/sdks/python/apache_beam/io/avroio_test.py#L198-L206) failed. Is it safe to change the implementation of this function to bypass negative value? If it it is oke, I have a [PR](https://github.com/apache/beam/pull/34542) to resolve it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
