portikCoder commented on PR #34248: URL: https://github.com/apache/beam/pull/34248#issuecomment-2738503945
> > Hi @portikCoder - friendly reminder to check out the failing checks. Thanks. > > Hi. Thanks for reminder, no worries I have it in my TODO list, will be done today/tmrw. I was thinking it's better to add a test covering this case, hope its intent is clear enough. Probably I should have mocked a tad more to speed things there up a bit, but I think ultimately it boils down to documentation like test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org