claudevdm commented on PR #34394: URL: https://github.com/apache/beam/pull/34394#issuecomment-2748665701
> also if the purpose is > > > bypassing the requirement to grant database access to machine where pipeline is built/submitted for partition bound inference. > > we should be able to change here > > https://github.com/apache/beam/blob/3595a3303df6d2e4c8e77482ca8120994d0d5881/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java#L1513 > > to use explicit schema, if partition type is set at pipeline expansion time (and not need to pass in lower and upper bound) I don't follow. From my experience there are two cases where the database is accessed during expansion time: 1. Infer schema 2. Get partition bounds For ReadWithPartitions, both partition bounds and schema need to be explicitly provided to avoid database queries during expansion time. There is already support for explicitly providing schema https://github.com/apache/beam/blob/3595a3303df6d2e4c8e77482ca8120994d0d5881/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java#L1562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
